Make at::vec::Vectorized ops work with scalars #150380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

swolchok wants to merge 6 commits into gh/swolchok/727/base from gh/swolchok/727/head

Contributor

swolchok commented Apr 1, 2025 •

edited by pytorchmergebot

Loading

Stack from ghstack (oldest at bottom):

I noticed that I couldn't use vec::Vectorized operations with scalars, even though there is an implicit conversion from T to vec::Vectorized<T>, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10


          Update

[ghstack-poisoned]

pytorch-bot bot commented Apr 1, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150380

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ed186e4 with merge base caf8d9b ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the module: cpu label

swolchok added a commit that referenced this pull request


          Make at::vec::Vectorized ops work with scalars

707fbee

I noticed that I couldn't use `vec::Vectorized` operations with scalars, even though there is an implicit conversion from `T` to `vec::Vectorized<T>`, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

ghstack-source-id: 6fce62e30b7ba4a6ad6f786c0412dcc046b0f4d8
Pull Request resolved: #150380

swolchok requested review from r-barnes, zhuhaozhe and malfet

April 1, 2025 02:09

Skylion007 reviewed

View reviewed changes

aten/src/ATen/cpu/vec/vec_base.h Outdated

                 return c;
               }
+                VECTORIZED_SUPPORT_SCALARS_FOR_BINARY_OP(+)

Collaborator

Skylion007 Apr 1, 2025

What's with the indentation?

Contributor Author

swolchok Apr 1, 2025

it's what my editor wanted to do. this file isn't formatted by lintrunner :\

Contributor Author

swolchok Apr 1, 2025 •

edited

Loading

sent PR to autoformat top-level vec headers

swolchok mentioned this pull request

clang-format aten/src/ATen/cpu/vec/*.h #150425

Closed


          Update

b45497c

[ghstack-poisoned]

swolchok mentioned this pull request

clang-format aten/src/ATen/cpu/vec/*.h #150426

Closed

swolchok added a commit that referenced this pull request


          Make at::vec::Vectorized ops work with scalars

905fe46

I noticed that I couldn't use `vec::Vectorized` operations with scalars, even though there is an implicit conversion from `T` to `vec::Vectorized<T>`, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

ghstack-source-id: 1c229f424c6ccc72eb9d10a6c8e2293c7890dcc7
Pull Request resolved: #150380

swolchok added the release notes: cpp label

swolchok requested a review from Skylion007

April 1, 2025 17:06

swolchok mentioned this pull request

Add vectorization in elementwise_util pytorch/executorch#9432

Draft


          Update

aac561b

[ghstack-poisoned]

swolchok added a commit that referenced this pull request


          Make at::vec::Vectorized ops work with scalars

57d30ce

I noticed that I couldn't use `vec::Vectorized` operations with scalars, even though there is an implicit conversion from `T` to `vec::Vectorized<T>`, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

ghstack-source-id: b000faca381a09cae767a2751bce90cf8e11bc08
Pull Request resolved: #150380


          Update

a816e20

[ghstack-poisoned]

swolchok mentioned this pull request

Overload unary - operator on at::vec::Vectorized to call neg() #150568

Closed


          Update

89b2b6c

[ghstack-poisoned]

Contributor Author

swolchok commented Apr 3, 2025

ping

pytorchmergebot pushed a commit that referenced this pull request


          clang-format aten/src/ATen/cpu/vec/*.h (#150426)

ed0fd2f

I got a complaint about indentation on #150380. Make the machines fix it for us.

Pull Request resolved: #150426
Approved by: https://github.com/aditew01, https://github.com/cyyever, https://github.com/frost-intel, https://github.com/Skylion007

Collaborator

pytorchmergebot commented Apr 4, 2025

Starting merge as part of PR stack under #150568

1 similar comment

Collaborator

pytorchmergebot commented Apr 4, 2025

Starting merge as part of PR stack under #150568

Contributor Author

swolchok commented Apr 4, 2025

@Skylion007 can you please take another look?

Skylion007 approved these changes

View reviewed changes

Collaborator

pytorchmergebot commented Apr 5, 2025

Starting merge as part of PR stack under #150568

1 similar comment

Collaborator

pytorchmergebot commented Apr 6, 2025

Starting merge as part of PR stack under #150568


          Update

ed186e4

[ghstack-poisoned]

Collaborator

pytorchmergebot commented Apr 6, 2025

Rebased gh/swolchok/730/orig onto refs/remotes/origin/viable/strict because #150568 was rebased, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/150380)

Collaborator

pytorchmergebot commented Apr 6, 2025

Starting merge as part of PR stack under #150568

pytorchmergebot closed this in

912102b

pytorchmergebot pushed a commit that referenced this pull request


          Overload unary - operator on at::vec::Vectorized to call neg() (#150568)

0aaf353

Makes Vectorized look even more like a scalar type, getting me closer to being able to use the same generic code with scalars and Vectorized (e.g., for sigmoid, which needs `exp(-x)`).

Pull Request resolved: #150568
Approved by: https://github.com/Skylion007
ghstack dependencies: #150380

pytorchmergebot added the Merged label

timocafe pushed a commit to timocafe/pytorch that referenced this pull request


          clang-format aten/src/ATen/cpu/vec/*.h (pytorch#150426)

67188a6

I got a complaint about indentation on pytorch#150380. Make the machines fix it for us.

Pull Request resolved: pytorch#150426
Approved by: https://github.com/aditew01, https://github.com/cyyever, https://github.com/frost-intel, https://github.com/Skylion007

timocafe pushed a commit to timocafe/pytorch that referenced this pull request


          Make at::vec::Vectorized ops work with scalars (pytorch#150380)

c83da62

I noticed that I couldn't use `vec::Vectorized` operations with scalars, even though there is an implicit conversion from `T` to `vec::Vectorized<T>`, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

Pull Request resolved: pytorch#150380
Approved by: https://github.com/Skylion007

timocafe pushed a commit to timocafe/pytorch that referenced this pull request


          Overload unary - operator on at::vec::Vectorized to call neg() (pytor…

3d60031

…ch#150568)

Makes Vectorized look even more like a scalar type, getting me closer to being able to use the same generic code with scalars and Vectorized (e.g., for sigmoid, which needs `exp(-x)`).

Pull Request resolved: pytorch#150568
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#150380

amathewc pushed a commit to amathewc/pytorch that referenced this pull request


          clang-format aten/src/ATen/cpu/vec/*.h (pytorch#150426)

4e6daea

I got a complaint about indentation on pytorch#150380. Make the machines fix it for us.

Pull Request resolved: pytorch#150426
Approved by: https://github.com/aditew01, https://github.com/cyyever, https://github.com/frost-intel, https://github.com/Skylion007

amathewc pushed a commit to amathewc/pytorch that referenced this pull request


          Make at::vec::Vectorized ops work with scalars (pytorch#150380)

3b3b481

I noticed that I couldn't use `vec::Vectorized` operations with scalars, even though there is an implicit conversion from `T` to `vec::Vectorized<T>`, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

Pull Request resolved: pytorch#150380
Approved by: https://github.com/Skylion007

amathewc pushed a commit to amathewc/pytorch that referenced this pull request


          Overload unary - operator on at::vec::Vectorized to call neg() (pytor…

cb85295

…ch#150568)

Makes Vectorized look even more like a scalar type, getting me closer to being able to use the same generic code with scalars and Vectorized (e.g., for sigmoid, which needs `exp(-x)`).

Pull Request resolved: pytorch#150568
Approved by: https://github.com/Skylion007
ghstack dependencies: pytorch#150380

Divigroup-RAP pushed a commit to Divigroup-RAP/PYTORCH that referenced this pull request


          Make at::vec::Vectorized ops work with scalars

e532f06

I noticed that I couldn't use `vec::Vectorized` operations with scalars, even though there is an implicit conversion from `T` to `vec::Vectorized<T>`, so I made it work.

Test Plan: Added tests. Reverted vec_base.h, left the new tests in place, and confirmed that new tests don't compile in that state.

ghstack-source-id: 8ae256b5f0a68bb8067116e7879fe47f3a00107a
Pull Request resolved: pytorch/pytorch#150380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cpu release notes: cpp