Fixes and improvements #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Jan 15, 2017
fmassa
reviewed
Jan 15, 2017
| valid as long as it's used by them. You should be careful and ensure that | ||
| CUDA tensors you shared don't go out of scope as long as it's necessary. | ||
| This shouldn't be a problem for sharing model parameters, but passing other | ||
| kinds of data should be done with care. Nore that this restriction doesn't |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
apaszke
force-pushed
the
fixes_v2
branch
5 times, most recently
from
1e239f7 to
1566e17
Compare
This was referenced Jan 16, 2017
ashishfarmer
pushed a commit
to ashishfarmer/pytorch
that referenced
this pull request
Oct 3, 2019
Skip test failing only on hip-clang to unblock them.
mrshenli
pushed a commit
to mrshenli/pytorch
that referenced
this pull request
Apr 11, 2020
jjsjann123
pushed a commit
to jjsjann123/pytorch
that referenced
this pull request
Nov 25, 2020
* Fix cache_before Currently, cache_before seems to have two problems. First, when the cached tensor has reductions, its IterDomain expression history is lost as it gets a new TensorDomain with only its root domains minus the reduction domains. Second, using computeAt does not necessarily generate correct computeAt relationships. For example, in the CacheBefore test, T1's computeAt tensor is still T2 even after cache_before. It should be the cache tensor instead. A test case is also added. See pytorch#408 as well. Closes pytorch#408 * clang-tidy * Review feedback * clang-format * Fix computeAt setting with reduction domains * Add a missing break
KyleCZH
pushed a commit
to KyleCZH/pytorch
that referenced
this pull request
Sep 20, 2021
Signed-off-by: Eli Uriegas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paramsis not a Variable nor a tensor (optim.Optimizer() - Missing argument type check for single parameter #433)pargument (check dropout input #403)torch.topkoptions (bug in kwargs parser for bools #432)torch.randn(2, 3, 4, asdf=False)now raises an error (earlier invalid kwargs were ignored)nn.Containers are now copyable (add copy.deepcopy support to nn.Container models #415)