Skip to content

Allow disabling activation offloading streams in full finetune recipe #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nathan-az
Copy link
Contributor

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

Please link to any issues this PR addresses.

#2683

Changelog

What are the changes made in this PR?

  • Allows configuring use_streams in activation offloading

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2710

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 544eedd with merge base 3310946 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
@nathan-az
Copy link
Contributor Author

nathan-az commented May 9, 2025

@joecummings @janeyx99 @ebsmothers Let me know if this looks like a reasonable stopgap. I'm not certain that it completely solves the issue (also curious if anyone can repro both the instability, and that this change fixes it). I assume that if the issue is the streams, fixing it properly may be quite a bit higher effort.

@janeyx99
Copy link
Contributor

janeyx99 commented May 9, 2025

@nathan-az I think allowing a nonstreams option is good! Your inclination is right that if it is streams that’s the problem, it will be nontrivial to fix.

Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathan-az thanks for opening this! I agree, this looks like a reasonable fix to unblock TP with activation offloading

@ebsmothers ebsmothers merged commit c3c532a into pytorch:main May 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants