Skip to content

Fix flaky compute_world_size test on devservers and make pyre happy #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

kiukchung
Copy link
Contributor

Summary: Fixes tests that are flaky when running locally on devservers. Makes pyre happy for type checking //torchx/schedulers/fb:ray_scheduler

Reviewed By: manav-a, hstonec, tonykao8080

Differential Revision: D71576534

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 27, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71576534

Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

kiukchung added a commit that referenced this pull request Mar 27, 2025
…1030)

Summary:

Fixes tests that are flaky when running locally on devservers. Makes pyre happy for type checking `//torchx/schedulers/fb:ray_scheduler`

Reviewed By: manav-a, hstonec, tonykao8080

Differential Revision: D71576534
…1030)

Summary:
Pull Request resolved: #1030

Fixes tests that are flaky when running locally on devservers. Makes pyre happy for type checking `//torchx/schedulers/fb:ray_scheduler`

Reviewed By: manav-a, hstonec, tonykao8080

Differential Revision: D71576534
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D71576534

@facebook-github-bot facebook-github-bot merged commit bde0ec9 into main Mar 27, 2025
19 of 23 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D71576534 branch March 27, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants