handle components whose implementation lives in a different file #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
May 29, 2025
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
f3f9002 to
2a129b6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
May 29, 2025
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
2a129b6 to
005b5d5
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
May 29, 2025
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
005b5d5 to
9590188
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
May 29, 2025
…orch#1075) Summary: Pull Request resolved: pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
9590188 to
8652b4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
May 29, 2025
…orch#1075) Summary: Pull Request resolved: pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
8652b4f to
78e9b5b
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Jun 2, 2025
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
78e9b5b to
1bf54ab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
1bf54ab to
1eba6d0
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Jun 2, 2025
…orch#1075) Summary: Pull Request resolved: pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
1eba6d0 to
5de962f
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Jun 2, 2025
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Jun 2, 2025
…orch#1075) Summary: Pull Request resolved: pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
5de962f to
83a2af4
Compare
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Jun 3, 2025
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
83a2af4 to
9c22799
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
daniel-ohayon
pushed a commit
to daniel-ohayon/torchx
that referenced
this pull request
Jun 3, 2025
…orch#1075) Summary: Pull Request resolved: pytorch#1075 Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
9c22799 to
bf91c0c
Compare
…orch#1075) Summary: Add support for cases like: ```lang=python # some_file.py # ==================== def my_component(...) -> specs.AppDef: ... # other_file.py # ==================== from some_file import my_component ``` where the component is invoked with `torchx run ... other_file.py:my_component` This was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented. Reviewed By: kiukchung Differential Revision: D75496839
daniel-ohayon
force-pushed
the
export-D75496839
branch
from
bf91c0c to
ec1c0de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75496839 |
kiukchung
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add support for cases like:
where the component is invoked with
torchx run ... other_file.py:my_componentThis was currently failing with a validation error because in the step where we inspect the AST of the component, we assume that the file where the component is being looked up is the same as the file where it is implemented.
Differential Revision: D75496839