Skip to content

Replaces gym with gymnasium in reinforcement learning q-learning tutorial #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2023
Merged

Replaces gym with gymnasium in reinforcement learning q-learning tutorial #2170

merged 2 commits into from
Jan 23, 2023

Conversation

pseudo-rnd-thoughts
Copy link
Contributor

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Jan 11, 2023 •
edited
Loading

Gymnasium is a fork of OpenAI gym that is developed by the same team that maintained Gym since v0.19-v0.26

You can read more about the reason for the fork in https://farama.org/Announcing-The-Farama-Foundation

In this PR, I have replaced the instances of Gym with gymnasium and removed old code that provided support for Gym v0.25

@vmoens Let me know if there is anything else you would like me to change

@facebook-github-bot
Copy link
Contributor

Hi @pseudo-rnd-thoughts!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@svekars svekars requested review from vmoens and malfet January 11, 2023 21:00
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

vmoens
vmoens approved these changes Jan 14, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this change

@netlify
Copy link

netlify bot commented Jan 23, 2023

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 64d7eee
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/63ced938992baa0008f7f9bc
😎 Deploy Preview https://deploy-preview-2170--pytorch-tutorials-preview.netlify.app/intermediate/reinforcement_q_learning
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vmoens vmoens merged commit b24c7c3 into pytorch:main Jan 23, 2023
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the gymnasium branch November 3, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pseudo-rnd-thoughts @facebook-github-bot @vmoens