Skip to content

[docathon] Update tensorboard_profiler_tutorial.py to work #2602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

aaronenyeshi
Copy link
Member

@aaronenyeshi aaronenyeshi commented Oct 11, 2023

Description

There is a bug when combining with_stack=True and repeat>1. So we set repeat=1 for this example. Also, I've added notes that tensorboard plugin is being deprecated, and replaced by HTA. We will have a new tutorial for using HTA in the upcoming months.

Fixes pytorch/pytorch#109969

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @chaekit

There is a bug when combining with_stack=True and repeat>1. So we set repeat=1 for this example. Also, I've added notes that tensorboard plugin is being deprecated, and replaced by HTA. We will have a new tutorial for using HTA in the upcoming months.
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2602

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 27397e8 with merge base 127d239 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@aaronenyeshi
Copy link
Member Author

@svekars and @dhanup07 can you please help review and accept these changes if they look OK?

Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@aaronenyeshi aaronenyeshi changed the title Update tensorboard_profiler_tutorial.py to work [docathon] Update tensorboard_profiler_tutorial.py to work Oct 11, 2023
@aaronenyeshi aaronenyeshi merged commit 5003542 into pytorch:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

profiler doesn't work with multiple workers
3 participants