Skip to content

updated the code to avoid deepcopy() #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

updated the code to avoid deepcopy() #2648

wants to merge 2 commits into from

Conversation

saurabhkthakur
Copy link

@saurabhkthakur saurabhkthakur commented Nov 4, 2023 •
edited by pytorch-bot bot
Loading

Fixes #2335

Description

since we need to avoid deepcopy() to create sequential network, i created a new method _build_cnn which returns the same network.

Checklist

cc @albanD @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2648

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a4185e7 with merge base 77aec05 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @saurabhkthakur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@github-actions github-actions bot added core Tutorials of any level of difficulty related to the core pytorch functionality easy docathon-h2-2023 labels Nov 4, 2023
@saurabhkthakur saurabhkthakur reopened this Nov 4, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

albanD
albanD approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svekars
Copy link
Contributor

svekars commented Nov 6, 2023

Please resolve the merge conflict

@svekars
Copy link
Contributor

svekars commented Nov 7, 2023

Fixed by #2649

@svekars svekars closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h2-2023 easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update tutorial to avoid use of copy.deepcopy()-Train a Mario-playing RL Agent
4 participants
@saurabhkthakur @facebook-github-bot @svekars @albanD