fix anti-pattern for cudagraph #9081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9081
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5a9709a with merge base 11ed64e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ydwu4
approved these changes
May 22, 2025
|
@pytorchbot merge -f "skip unrelated lint issue" |
|
Mergebot is not configured for this repository. Please use the merge button provided by GitHub. |
|
Hey @BoyuanFeng! You merged this PR, but no labels were added. |
|
Hi folks, Sorry but I have to revert this PR as it is BC-breaking. Happy to consider alternative fixes (ideally, with non-regression tests), but next time please do allow time for a maintainer's review. |
NicolasHug
added a commit
to NicolasHug/vision
that referenced
this pull request
May 29, 2025
This reverts commit 966da7e.
NicolasHug
added a commit
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
self.set_cell_anchors(dtype, device)leads to cudagraph error "accessing tensor output of CUDAGraphs that has been overwritten by a subsequent run". This pr fixes the anti-pattern to enable cudagraph.