fix issue qubvel/segmentation_models.pytorch#377 #561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
rebased on master 740dab5 |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
This PR was closed because it has been stalled for 15 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thank you for sharing your great work.
I faced the issue #377 and tried to fix it.
I have found that the tensor shapes of
aspp_featuresandhigh_res_featuresinDeepLabV3PlusDecoder.forwarddo not match, and they cannot be concatenated.After some investigation, the index for the encoder output that
DeepLabV3PlusDecoder.block1should accept need to be set suitable for the value ofencoder_depthandencoder_output_stride.Just for your information, I attach a text to see the combination of tensor shapes.
tensor_shapes.md
I appreciate any comment. Thanks in advance!
(edit)
I noticed that in case
encoder_depthandencoder_output_strideare 3 and 16 respectively, the argumentupsamplingofDeepLabV3Plusneeds to be set to 2 to obtain the same output shape as input.I think this setting of
upsamplingmay be included in docstring, and made another commit in the pull request.