-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Update ruff to version 0.5.2 and workflows update #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @Smartappli , thanks for the opening PR! |
Hi @qubvel, its ready |
Can you please alse update ruff in setup.py? |
One more note here, can you please pin timm version back? It's going to be updated in another PR, thanks. |
@qubvel ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, a few more comments below. Moreover, CI fails due to changed ruff configuration
Sorry, probably there was a kind of misunderstanding, I thins exclude is necessary, but I asked about what was the motivation to add |
Its |
Sorry, I cannot merge it this way because it breaks CI. I suggest moving ruff config change to a separate PR and keeping here just ruff version change to be able to pass the CI checks. In next PR the config might be created and changed, then ruff formatting applied to reflect config changes. |
reverted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for iterating!
Workflow updated