Skip to content

silance "is" with 'str' literal syntax warning from pretrainedmodels in python >= 3.12 #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

silance "is" with 'str' literal syntax warning from pretrainedmodels in python >= 3.12 #987

merged 1 commit into from
Nov 29, 2024

Conversation

YoniChechik
Copy link
Contributor

No description provided.

@adamjstewart
Copy link
Collaborator

I would really like to remove dependencies on these unmaintained libraries and replace them with timm: #918 (comment)

@YoniChechik
Copy link
Contributor Author

@adamjstewart This sounds amazing. But in the meantime we can merge this fix for a quick patch.

@qubvel
Copy link
Collaborator

qubvel commented Nov 29, 2024

Thanks for update!

@qubvel qubvel merged commit d490cdf into qubvel-org:main Nov 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YoniChechik @adamjstewart @qubvel