Add --retries parameter to CLI commands
#5748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
force-pushed
the
guilload/rest-client-retries
branch
from
5ee1e44 to
eb9220b
Compare
trinity-1686a
approved these changes
Apr 16, 2025
| .tls_built_in_root_certs(false) | ||
| .add_root_certificate(ca_cert); | ||
| } | ||
| let retry_policy = ExponentialBackoff::builder().build_with_max_retries(num_retries); |
There was a problem hiding this comment.
the default max backoff seems to be 30m, that seems overly long for a cli. i'd be in favor of capping that to a few minutes
There was a problem hiding this comment.
Fair, let me tweak the retry policy.
|
|
||
| assert!(matches!(error, Error::Client(_))); | ||
| assert!(error.to_string().contains("tcp connect error")); | ||
| assert!(matches!(error, Error::Middleware(_))); |
There was a problem hiding this comment.
can we assert that we still say something about a tcp connect error? i don't know how this error stringify itself, but if it says nothing about the underlying situation, it's not really useful to the (human) consumer
guilload
force-pushed
the
guilload/rest-client-retries
branch
2 times, most recently
from
0b14956 to
c06c34d
Compare
guilload
force-pushed
the
guilload/rest-client-retries
branch
from
c06c34d to
96f34f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--retriesparameter to CLI commandsI got pulled into updating OpenDAL in order to use
reqwest-middlewareandreqwest-retry.How was this PR tested?