Skip to content

Fix #1429 #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fix #1429 #1431

merged 1 commit into from
Dec 1, 2023

Conversation

lukebakken
Copy link
Collaborator

Fixes #1429

@lukebakken lukebakken added this to the 7.0.0 milestone Nov 29, 2023
@lukebakken lukebakken self-assigned this Nov 29, 2023
@lukebakken lukebakken mentioned this pull request Nov 29, 2023
Closed
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1429 branch from 633b909 to 5098413 Compare November 29, 2023 20:51
@lukebakken lukebakken mentioned this pull request Nov 29, 2023
Merged
lukebakken added a commit that referenced this pull request Nov 29, 2023
@lukebakken
Fixes #1429 for 6.x
2253184 
See #1431

* Modify test program to demonstrate the issue
* Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
lukebakken added a commit that referenced this pull request Nov 29, 2023
@lukebakken
Fixes #1429 for 6.x
37c7e9e 
See #1431

* Modify test program to demonstrate the issue
* Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
Pliner
Pliner reviewed Nov 30, 2023
View reviewed changes
@lukebakken
Fixes #1429 in main
21ecfb1 
* Add test that demonstrates the failure in #1429
* Refactor OAuth2 tests to use Async API
* Fix issue by allowing multiple registrations of the same ICredentialsProvider instance
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1429 branch from 5098413 to 21ecfb1 Compare November 30, 2023 16:09
lukebakken added a commit that referenced this pull request Nov 30, 2023
@lukebakken
Fixes #1429 for 6.x
27d5fb8 
See #1431

* Modify test program to demonstrate the issue
* Fix underlying issue by allowing multiple Register calls for the same instance of ICredentialsProvider
@lukebakken lukebakken merged commit 55a33e2 into main Dec 1, 2023
@lukebakken lukebakken deleted the rabbitmq-dotnet-client-1429 branch December 1, 2023 21:54
@paulomorgado
Copy link
Contributor

LGTM

MarcialRosales
MarcialRosales reviewed Dec 5, 2023
View reviewed changes
Copy link
Contributor

@MarcialRosales MarcialRosales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me . Thanks @lukebakken for taking care of it.

@Jakimar Jakimar mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcialRosales MarcialRosales MarcialRosales left review comments

@Pliner Pliner Awaiting requested review from Pliner

@paulomorgado paulomorgado Awaiting requested review from paulomorgado

Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Opening multiple connections from a ConnectionFactory with CredentialsRefresher makes the second connection fail
4 participants
@lukebakken @paulomorgado @Pliner @MarcialRosales