Skip to content

Changed ClientProperty after recovery in connection.created message #861

Open
@mheidt

Description

@mheidt

Hello,

We are using this version
com.rabbitmq
amqp-client
5.15.0

But 3.16.0 hasn't changed in the following regards.

We are facing the issue that we need a unique identifier that should change after each connection incl. automatic recovery.
That's why we added this UUID into the clientProperties of the connection via ConnectionFactory.
Everything works but the initial connection.created message the rabbit server is sending after a recovery.
Here we see the old UUID still.
We tried to change the property in the recoveryStarted call.

But when I look into the source code, we don't have any chance to do this.

AutorecoveringConnection stores params, which are not accessible from outside but in parts through a delegate that is created as RecoveryAwareAMQConnection using this params.
Unfortunately they are stored as a new HashMap in AMQConnection:
this._clientProperties = new HashMap(params.getClientProperties());
As well as whole as params in RecoveryAwareAMQConnectionFactory.

The AutorecoveringConnection.recoverConnection is calling the internal ConnectionFactory (not ours) to create a newConnection which is using the stored params, which is not accessible for us.

As I previously said, the first call of recoveryStart is too late for us to make any modification, because we need this changed clientProperty in the first communication (connection.created message) that is made before any channel activity.

Or is there a way to do this anyhow?
In my small opinion the clientProperties of the delegate of the current connection should be used for the new connection instead of the initially stored params of the factory.

Kind regards,
Markus Heidt

I know, I hate those cases as well :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions