Skip to content

4.1, by @Ayanda-D: stop QQ replicas when a QQ is forced to shrink to a single replica #12468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

michaelklishin
Copy link
Collaborator

This is #12427 by @Ayanda-D.

Shrinking operations did not stop QQ replicas. This was easy to miss because QQs are usually shrunk before a node is removed from the cluster.

However, there is a scenario where this is not the case. If some nodes (replicas) need to be replaced, in particular when a majority of nodes cannot be recovered for any reasons, the recovery process will involve shrinking a QQ to just one member so that it has an online quorum (of 1 node out of 1) before new replicas can be added.

For this to succeed, the older replicas must be stopped and deleted from the (QQ) cluster.

@michaelklishin
Copy link
Collaborator Author

@Ayanda-D the failure on Erlang 27 in ct_logs have nothing to do with this change. Nonetheless, this PR may have to wait until more CI-related changes land into main.

@rabbitmq rabbitmq deleted a comment from mergify bot Oct 7, 2024
@michaelklishin michaelklishin changed the title By @Ayanda-D: stop QQ replicas when a QQ is forced to shrink to a single replica 4.1, by @Ayanda-D: stop QQ replicas when a QQ is forced to shrink to a single replica Oct 7, 2024
@michaelklishin
Copy link
Collaborator Author

The failures seem to be unrelated to the changes here.

See erlang/otp#8908 and erlang/otp#8911.

@michaelklishin michaelklishin merged commit 83d094d into main Oct 8, 2024
395 of 399 checks passed
@michaelklishin michaelklishin deleted the rabbitmq-server-12427 branch October 8, 2024 00:46
Copy link

mergify bot commented Oct 8, 2024

backport v4.0.x v3.13.x

✅ Backports have been created

@Ayanda-D
Copy link
Contributor

Ayanda-D commented Oct 8, 2024

@michaelklishin Thank you! 🙏

@Ayanda-D
Copy link
Contributor

Ayanda-D commented Oct 8, 2024

@rabbitmq rabbitmq deleted a comment from mergify bot Oct 10, 2024
@michaelklishin
Copy link
Collaborator Author

FTR, this was backported to v4.0.x manually.

v3.13.x is now only covered by commercial support so if we backport this change to v3.13.x, it will ship in the commercial edition (Tanzu RabbitMQ).

@michaelklishin michaelklishin added this to the 4.0.3 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants