Skip to content

Remove deprecated TlsConfiguration#hostnameVerification methods #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Remove deprecated TlsConfiguration#hostnameVerification methods #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/main/java/com/rabbitmq/stream/EnvironmentBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,31 +436,6 @@ EnvironmentBuilder topologyUpdateBackOffDelayPolicy(
/** Helper to configure TLS. */
interface TlsConfiguration {

/**
* Enable hostname verification.
*
* <p>Hostname verification is enabled by default.
*
* @return the TLS configuration helper
* @deprecated use {@link SslContextBuilder#endpointIdentificationAlgorithm(String)} with {@link
* #sslContext(SslContext)}
*/
@Deprecated(forRemoval = true)
TlsConfiguration hostnameVerification();

/**
* Enable or disable hostname verification.
*
* <p>Hostname verification is enabled by default.
*
* @param hostnameVerification whether to enable hostname verification or not
* @return the TLS configuration helper
* @deprecated use {@link SslContextBuilder#endpointIdentificationAlgorithm(String)} with {@link
* #sslContext(SslContext)}
*/
@Deprecated(forRemoval = true)
TlsConfiguration hostnameVerification(boolean hostnameVerification);

/**
* Netty {@link SslContext} for TLS connections.
*
Expand Down
14 changes: 0 additions & 14 deletions src/main/java/com/rabbitmq/stream/impl/StreamEnvironmentBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,20 +372,6 @@ private DefaultTlsConfiguration(EnvironmentBuilder environmentBuilder) {
this.environmentBuilder = environmentBuilder;
}

@Override
@SuppressWarnings("removal")
public TlsConfiguration hostnameVerification() {
this.hostnameVerification = true;
return this;
}

@Override
@SuppressWarnings("removal")
public TlsConfiguration hostnameVerification(boolean hostnameVerification) {
this.hostnameVerification = hostnameVerification;
return this;
}

@Override
public TlsConfiguration sslContext(SslContext sslContext) {
this.sslContext = sslContext;
Expand Down