Discussion: gracefully upgrading

[ramontayag]

Apologies if this doesn't belong here. I couldn't find a mailing list, and this does not seem to fit StackOverflow.

I'm working on a bunch of apps that use AMS 0.8.x to 0.9.x. Upgrading to 0.10.x will break the API endpoints of my apps. How do you recommend we upgrade gracefully? An example: create a fork of AMS with a different namespace (e.g. ActiveModel::SerializersOld). The v1 API endpoints of the apps will use this forked gem. Then, create v2 endpoints that uses the new ActiveModel::Serializers 0.10.x gem.

[bf4]

Maybe we could make adapters? Some of this discussion will be addressed in the docs #994

[shicholas]

I think your idea of making serializer adapters is great. Are you thinking something like a version_8 adapter and a version_9 one?

[shicholas]

@ramontayag I took your advice and created https://github.com/shicholas/active_model_serializers/tree/0-8-with-namespacing. This way we can require both 0.10 and 0.8 in the same project with the later being ActiveModel::SerializerVersion8.

[bf4]

Watch out for any behavior it mixes in when required esp the controller

[shicholas]

thanks for the heads up.

[ramontayag]

Yes I took a quick stab at it and there are issues with the stuff AMS injects in the controller

[shicholas]

I've been noticing the same thing, so I opted to create a controller concern around the code in #1002 (comment). @bf4, is anyone working on a version_8 adapter for version 0.10? I can take a stab at it

[joaomdmoura]

Hey you all! sorry for take so long to reply, I'm on a kind of business trip 😄
So, first of all, enable people to upgrade from older version is definitely a priority for us!
I totally agree that we should address it on the new docs structure. Probably a guide from ppl upgrading from 0.8 and another from 0.9. what they will need to change in order to make it happen.

I'm not sure about the adapter think yet, I'm still thinking about it. I didn't want to bring some of the old logic to this new version, but we can discuss that with other members as well later.
Anyway, the adapter is a valid solution and if we had and adapter, even if it was outside the project, we would still distribute it trough the docs tutorial for sure!

@shicholas I'm almost sure there isn't anyone working on that so far. If you want to keep track of it make yourself comfortable to open a WIP PR.

[bf4]

Bump, if anyone wanna help with docs or code?