Links generation should be optional when using json-api adapter with kaminari or will_paginate.

[youroff]

The links just automatically showed up with one of recent updates. Correct me if I'm wrong, but I haven't found how to turn them off right away. Shouldn't it be optional?

[bf4]

@youroff Hi! Thanks for writing! You're right that it's not documented. I just took a look at the code ant it looks like you can:

class NonPaginatedCollectionSerializer < ActiveModel::Serializer::CollectionSerializer
  def paginated?
    false
  end
end
ActiveModelSerializers.config.collection_serializer = NonPaginatedCollectionSerializer

ref:

• https://github.com/rails-api/active_model_serializers/blob/v0.10.0.rc4/lib/active_model/serializer/collection_serializer.rb#L29-L33

• active_model_serializers/lib/active_model_serializers/adapter/json_api.rb

  Lines 71 to 73 in 8a04005

  	if is_collection && serializer.paginated?
  	hash[:links] ||= {}
  	hash[:links].update(pagination_links_for(serializer, options))

• https://github.com/rails-api/active_model_serializers/blob/v0.10.0.rc4/lib/active_model/serializer/configuration.rb#L11

Also, we've recently added issue templates and I haven't seen anyone using them. Are they perhaps not showing up?

[youroff]

That will work, but I think that global config would be better (probably, something like autopaginate: true), unless it's mandatory part of the response declared by json-api.

Yeah, I've noticed that, sorry. I thought as long as it wasn't an issue precisely (no trace, etc), I could write as is. Next will use it.

Just ran into another problem, again not sure if that's a bug or feature. So when decalred an association belongs_to and it doesn't listed in include option, serializer triggers load of relationship. Which is unnecessary as long as we have foreign keys on serializable model. Is that worth documenting as actual issue?

[victor95pc]

I have this same problem, I am making Rails + Ember integration, and I don't use this links.

I support a global option

[bf4]

@youroff

unless it's mandatory part of the response declared by json-api.

It's not mandatory, but having a pagination plugin makes it a good assumption you want to paginate... I'd accept a PR to disable it, with on being the default.

[bf4]

just ran into another problem, again not sure if that's a bug or feature. So when decalred an association belongs_to and it doesn't listed in include option, serializer triggers load of relationship. Which is unnecessary as long as we have foreign keys on serializable model. Is that worth documenting as actual issue?

Please create a new issue so we can discuss there.

[bf4]

Can we consider this resolved?

[victor95pc]

Thank you, for me this is not resolved until we make a PR, I want to do it, but I have some stuff(work) to do right now, maybe I can do this later.

[bf4]

@victor95pc Awesome. That gives me some room to work on getting more prs and issues resolved (when I'm not working :).

[youroff]

@bf4 not sure if using of pagination implies the need of links. I just use meta to pass total_pages and increment page when needed in the client app. Besides that ember-data generates urls on its own, not even sure if there's a way to pass link explicitly there.