0.10.stable / master is ignoring (key/root) option in has_many method

[bernEsp]

Example

has_many :charts, root: :rows,  serializer: ChartSerializer 

This produce a json with charts collection and ignore the custom name as follow

  { charts: [ ... ] }

When I'm expecting

   { rows: [ ... ] }

also fails using key option

  has_many :charts, key: :rows,  serializer: ChartSerializer

[bf4]

I think this is a feature request

[bernEsp]

@bf4 I think is backward compatibility. This functionality is a good option to avoid create a method just for customize the name of relationship

0.9 version
https://github.com/rails-api/active_model_serializers/tree/0-9-2#associations
0.8 version
https://github.com/rails-api/active_model_serializers/tree/0-8-stable#associations

[bf4]

Oh, my bad for not looking back. So, it's either a bug or a breaking change.

[maurogeorge]

Hi @joaomdmoura I try to write a broken test and got no success 😢
I think the #984 closes this issue. Could you please review this and close this issue if make sense?

Thanks

[bf4]

@bernardogalindo Does #984 resolve you issue so we can close this?

[bernEsp]

@bf4 I still having the same issues that I mentioned with the current master branch.

Version 0.9.3 allow me to do root=false to get

"{\"name\":\"Test\",\"parent_id\":null,\"subaccount_ids\":null}"

instead of

+"{\"object\":{\"name\":\"Test\",\"parent_id\":null,\"subaccount_ids\":null}

And allow me customize my the object keys as I mentioned

  { charts: [ ... ] }

When I'm expecting

   { rows: [ ... ] }

The current master branch still ignoring the root and key options