Add Running tests section on CONTRIBUTING #1221
Conversation
|
👍 |
| @@ -29,3 +29,23 @@ AMS uses a subset of [StandardIssueLabels](https://github.com/wagenet/StandardIs | |||
| 7. Create a new Pull Request | |||
|
|
|||
| Remember to squash your commits and rebase off `master`. | |||
|
|
|||
| ### Running tests | |||
There was a problem hiding this comment.
This should go, I think, in the README.. @rails-api/ams thoughts?
There was a problem hiding this comment.
@bf4 Most users probably do not really care about actually running the tests I believe. What's your rationale behind adding it to README?
There was a problem hiding this comment.
agree with @beauby ppl on readme are probably not looking into this 😁
|
👍 |
|
Thanks for the review. This is good to merge or I need to move this to README? I think the CONTRIBUTING is a better place, I think most people that download and run the tests are people the are contributing or trying contribute. I think the usual use case is add to gemfile and bundle it. |
|
|
||
| Rake can be found at http://docs.seattlerb.org/rake/. | ||
|
|
||
| #### Running by hand |
There was a problem hiding this comment.
I would remove this subtitle
There was a problem hiding this comment.
Agreed. Let's remove this subtitle.
|
Nice work here @maurogeorge I'm sure this is help ppk trying jump in the project! |
|
Thanks for the review guys. I updated the code 😄 |
|
LGTM, merging it. |
Add Running tests section on CONTRIBUTING
|
Thanks ❤️ |
No description provided.