Skip to content

Remove root_name class method from Serializer, as it is used nowhere. #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2015
Merged

Remove root_name class method from Serializer, as it is used nowhere. #1231

merged 1 commit into from
Oct 5, 2015

Conversation

beauby
Copy link
Contributor

@beauby beauby commented Oct 5, 2015

No description provided.

bf4
bf4 reviewed Oct 5, 2015
View reviewed changes
lib/active_model/serializer.rb
def self.root_name
name.demodulize.underscore.sub(/_serializer$/, '') if name
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz add a changelog entry that this is a breaking change (would be good to see where it was last used?), and I'll merge it

good catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@beauby
Copy link
Contributor Author

beauby commented Oct 5, 2015

Introduced here.

@NullVoxPopuli
Copy link
Contributor

I'm good with this! nice find!

@NullVoxPopuli
Copy link
Contributor

@bf4 should the changelog specifically state that this change is breaking?

@beauby
Copy link
Contributor Author

beauby commented Oct 5, 2015

@NullVoxPopuli As it was part of the public API, we have to inform people it is not anymore.

@NullVoxPopuli
Copy link
Contributor

yeah, I re-looked at the changelog and noticed I didn't notice earlier that the changelog entry was under Breaking Changes

we're good!

NullVoxPopuli added a commit that referenced this pull request Oct 5, 2015
@NullVoxPopuli
Merge pull request #1231 from beauby/remove-dead-code
ea1a709 
Remove `root_name` class method from Serializer, as it is used nowhere.
@NullVoxPopuli NullVoxPopuli merged commit ea1a709 into rails-api:master Oct 5, 2015
@bf4 bf4 deleted the remove-dead-code branch October 6, 2015 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Cleanup V: 0.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beauby @NullVoxPopuli @bf4 @joaomdmoura