Skip to content

Add benchmark regression runner #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2016

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Mar 13, 2016

Per #1575

@NullVoxPopuli
Copy link
Contributor

Do you plan on adding docs and examples?

@NullVoxPopuli
Copy link
Contributor

I mean, in the docs/ folder. I see you have in-line docs here. :-)

# super simple command line parsing
args = ARGV.dup
_ = args.shift
ref1 = args.shift # remove 'revisions' from args
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the comment be on the line above?

@groyoh
Copy link
Member

groyoh commented Mar 27, 2016

This looks good to me. We can create a follow up PRs afterward and adds docs there. Otherwise this PRwill stay open for a bit.

@groyoh groyoh merged commit 33a0f9c into rails-api:master Mar 27, 2016
@bf4 bf4 deleted the benchmark_revision_runner branch June 14, 2016 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants