Skip to content

Restrict serializable_hash to accepted options #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2016
Merged

Restrict serializable_hash to accepted options #1678

merged 1 commit into from
Apr 13, 2016

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Apr 11, 2016

Follows #1647

  • Restrict options
  • should root go to the adapter?
  • needs tests of ignored options

@groyoh
Copy link
Member

groyoh commented Apr 11, 2016

Root should definetely go to the adapter options IMO.

bf4
bf4 reviewed Apr 12, 2016
View reviewed changes
lib/active_model_serializers/adapter/attributes.rb
@@ -8,7 +8,7 @@ def initialize(serializer, options = {})
end

def serializable_hash(options = nil)
options ||= {}
options = serialization_options(options)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also see #965

@bf4 bf4 force-pushed the serialization_interface branch from 2f68ab4 to 929a5d0 Compare April 13, 2016 05:41
@bf4
Copy link
Member Author

bf4 commented Apr 13, 2016

@groyoh on reflection, the root to the ADAPTER_OPTION_KEYS is an unrelated concern (though I agree)

@bf4 bf4 added the V: 0.10.x label Apr 13, 2016
@bf4 bf4 merged commit e2ded59 into rails-api:master Apr 13, 2016
@bf4 bf4 deleted the serialization_interface branch April 13, 2016 05:59
@bf4 bf4 mentioned this pull request Apr 13, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
V: 0.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bf4 @groyoh