respect config.default_includes in #serializable_hash
#1762
Conversation
| @@ -151,7 +151,7 @@ def success? | |||
| # serializer.as_json(include: { posts: { include: { comments: { only: :body } }, only: :title } }) | |||
| def serializable_hash(adapter_opts = nil) | |||
| adapter_opts ||= {} | |||
| adapter_opts = { include: '*', adapter: :attributes }.merge!(adapter_opts) | |||
| adapter_opts = { include: config.default_includes, adapter: :attributes }.merge!(adapter_opts) | |||
There was a problem hiding this comment.
good call. would you mind adding a Changelog entry?
There was a problem hiding this comment.
but should be ActiveModelSerializer.default_includes, not config.default_includes
There was a problem hiding this comment.
You mean ActiveModelSerializers.config.default_includes? ActiveModelSerializers module does not have default_includes method, it is an error to ActiveModelSerializers.default_includes.
|
I merged some big refactoring in this area recently. Take a look and let me know how I can help with this PR. |
|
Thank you for pointing out! |
Purpose
default_includesconfig was added in #1426.However, it has not been used in
#serializable_hash, want to use it even#serializable_hash.Changes
Use
config.default_includesto default value of#serializable_hash.