Skip to content

Remove unnecessary Serializer#cached_fields; Extracted cached_attributes #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 1, 2016
Merged

Remove unnecessary Serializer#cached_fields; Extracted cached_attributes #1765

merged 4 commits into from
Jun 1, 2016

Conversation

bf4
Copy link
Member

@bf4 bf4 commented Jun 1, 2016 •
edited
Loading

  • Remove unnecessary Adapter::Base#resource_object_for
  • Remove unnecessary Serializer#cached_fields
  • Complete extracting to Serializer#cached_attributes; put cached_attributes in right spot
  • Simplify Serializer#cached_attributes to take a fields argument

Extracted from #1684

@bf4 bf4 force-pushed the serializer_cleanup_3 branch from 12e0fff to 385abb4 Compare June 1, 2016 06:02
@groyoh groyoh added the S: LGTM label Jun 1, 2016
@bf4 bf4 merged commit f2f747e into rails-api:master Jun 1, 2016
@bf4 bf4 deleted the serializer_cleanup_3 branch June 1, 2016 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Cleanup S: LGTM V: 0.10.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bf4 @groyoh