Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using multiple gsub! calls, this uses binary encoding to do the regexp gsub with map, then forces encoding back to UTF-8.
This uses the same approach as before ebe0c40, with binary encoding, which performs better.
Before:
After:
We can see it's a bit slower without anything to escape, but within the margin of error. We also think we can optimize gsub with a map on the Ruby side to avoid the allocations mentioned in #48669. cc @jhawthorn