Skip to content

Refactor to remove Rails dependency #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Feb 21, 2024

Addresses issue #156

solid_queue does not appear to depend on the whole Rails stack.

# bin/rails

require "rails"
# Pick the frameworks you want:
require "active_model/railtie"
require "active_job/railtie"
require "active_record/railtie"
# require "active_storage/engine"
require "action_controller/railtie"
# require "action_mailer/railtie"
require "action_view/railtie"
# require "action_cable/engine"
require "rails/test_unit/railtie"
require "rails/engine/commands"

This PR reduces dependencies to the following, but maybe it only needs railties?

# solid_queue.gemspec
  rails_version = ">= 7.1"
  spec.add_dependency "activerecord", rails_version
  spec.add_dependency "activejob", rails_version
  spec.add_dependency "railties", rails_version

@nimmolo nimmolo marked this pull request as ready for review February 23, 2024 02:59
@nimmolo nimmolo changed the title Remove Rails dependency Refactor to remove Rails dependency Feb 29, 2024
@rosa
Copy link
Member

rosa commented Mar 14, 2024

Hey @nimmolo, thanks for this and so sorry for the delay! I've been working on unrelated stuff the last couple of weeks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants