support nil logger and ActiveSupport::Logger not Logger #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy
reviewed
Mar 12, 2024
test/integration/processes_poller.rb
Outdated
| ensure | ||
| ActiveRecord::Base.logger = previous_logger | ||
| terminate_process(pid) if pid && process_exists?(pid) | ||
| end |
There was a problem hiding this comment.
Yeah I had a hard time trying to reproduce the bug, I don't know the library very well, so happy for pointers for better ways to do it
nbulaj
reviewed
Mar 21, 2024
| @@ -10,7 +10,7 @@ module Poller | |||
|
|
|||
| private | |||
| def with_polling_volume | |||
| if SolidQueue.silence_polling? | |||
| if SolidQueue.silence_polling? && ActiveRecord::Base.logger | |||
| ActiveRecord::Base.logger.silence { yield } | |||
There was a problem hiding this comment.
Maybe better just use safe-navigation ActiveRecord::Base.logger&.silence ?
There was a problem hiding this comment.
Then it will not yield
There was a problem hiding this comment.
But why? 🤔
irb(main):003> l = Logger.new(STDOUT)
irb(main):004> l.info { "OK" }
I, [2024-03-22T15:10:27.939697 #68513] INFO -- : OK
=> true
irb(main):005> l&.info { "OK" }
I, [2024-03-22T15:10:31.957994 #68513] INFO -- : OK
=> true
irb(main):008> n = nil
=> nil
irb(main):009> n&.info { "OK" }
=> nil
Or I'd better have to think an example with yield, yes
Add those as part of the tests for workers and dispatchers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #168