Stop SolidQueue on puma restart when puma plugin is used. #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashby
commented
Mar 23, 2024
|
|
||
| @pid = fork do | ||
| exec(*cmd) | ||
| Dir.chdir('test/dummy') do |
There was a problem hiding this comment.
I had to change the dir here this way instead of using --dir option because when you trigger puma's restart it can't find the app anymore since current dir is already test/dummy and it's trying to use test/dummy in addition.
nashby
force-pushed
the
puma-restart
branch
6 times, most recently
from
bc96173 to
56f7f02
Compare
Without doing so SolidQueue would be running making Puma not properly stop so whne Puma tries to start its process again we would get `Errno::EADDRINUSE` error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without doing so SolidQueue would be running making Puma not properly stop so when Puma tries to start its process again we would get
Errno::EADDRINUSEerror.Closes #180