Handle case of concurrency limit not being set in Semaphore #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid crashing in this case, just assume concurrency limit is 1. This shouldn't happen with normal operation but we've had this problem when jobs that are concurrency-limited are enqueued from new code and dispatched from old code, where the job still doesn't have concurrency controls.
That raises if the timeout is reached, instead of ignoring.
Sometimes 10 seconds is too short for Sqlite and the job ends up finishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid crashing in this case, just assume concurrency limit is 1. This shouldn't happen with normal operation but we've had this problem when jobs that are concurrency-limited are enqueued from new code and dispatched from old code, where the job still doesn't have concurrency controls, thus returning
nilfor the limit and crashing the dispatcher.