Truncate error backtrace when saving failed executions #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it can get really big for SystemStackError errors, and not fit in the DB text column. Assuming an average of 150 characters per backtrace line, limting to 400 would be around 60K characters plus the error name and error message, that are usually small, and the JSON attributes and other JSON serialization characters. This is the first approach to this. I'll change this to more sophisticated truncation that checks the column size and calculates how much it needs to truncate instead of using a fixed number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it can get really big for
SystemStackErrorerrors, and not fit in the DB text column.Assuming an average of 150 characters per backtrace line, limting to 400 would be around 60K characters plus the error name and error message, that are usually small, and the JSON attributes and other JSON serialization characters.
This is the first approach to this. I'll change this to more sophisticated truncation that checks the column size and calculates how much it needs to truncate instead of using a fixed number.