Skip to content

move gem instead of uninstalling and reinstalling to make test go fro… #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2015

Conversation

grosser
Copy link
Collaborator

@grosser grosser commented Aug 3, 2015

…m 20s->6s

looking into individual test speed now and this guys was one of the slowest, just moving the gem vs full uninstall+reinstall is a lot faster :)

@jonleighton

@rafaelfranca
Copy link
Member

@grosser I have granted commit access to the project so you can commit directly. Feel free to commit and thank you so much for the work.

@grosser
Copy link
Collaborator Author

grosser commented Aug 3, 2015

Thx! I'll still make PRs to get feedback :)

On Mon, Aug 3, 2015 at 11:17 AM, Rafael Mendonça França <
[email protected]> wrote:

@grosser https://github.com/grosser I have granted commit access to the
project so you can commit directly. Feel free to commit and thank you so
much for the work.


Reply to this email directly or view it on GitHub
#418 (comment).

@rafaelfranca
Copy link
Member

Of course.

@rafaelfranca
Copy link
Member

:shipit:

grosser added a commit that referenced this pull request Aug 3, 2015
move gem instead of uninstalling and reinstalling to make test go fro…
@grosser grosser merged commit 770b2b1 into rails:master Aug 3, 2015
@grosser grosser deleted the grosser/speed2 branch August 3, 2015 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants