Add WINCH to FORWARDED_SIGNALS #441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary, in conjunction with a change in ~/.irbrc, to enable terminal window resizing while using spring.
Signal.trap('SIGWINCH', proc { Readline.set_screen_size(*`stty size`.split.map(&:to_i)); Readline.refresh_line })
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @grosser (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
grosser
added a commit
that referenced
this pull request
Nov 10, 2015
Add WINCH to FORWARDED_SIGNALS
|
thx, looks good :) |
|
v1.4.1 |
kaspth
added a commit
that referenced
this pull request
Nov 10, 2015
Fix the CHANGELOG entry from #441
smartech7
pushed a commit
to smartech7/ruby-preloader-spring
that referenced
this pull request
Aug 4, 2023
The entry was added under the existing `1.4.0` release.
smartech7
pushed a commit
to smartech7/ruby-preloader-spring
that referenced
this pull request
Aug 4, 2023
Fix the CHANGELOG entry from rails/spring#441
JulianSage
added a commit
to JulianSage/spring
that referenced
this pull request
Oct 23, 2024
The entry was added under the existing `1.4.0` release.
JulianSage
added a commit
to JulianSage/spring
that referenced
this pull request
Oct 23, 2024
Fix the CHANGELOG entry from rails/spring#441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary, in conjunction with a change in ~/.irbrc, to enable terminal window resizing while using spring.