fix: sticky event loop by Copilot AI

[zombieJ]

UI 相关测试总是很蛋疼，模拟也不会有实际效果。

PS: Copilot 已经有点聪明了，可以根据提示来改对代码了。

ref ant-design/ant-design#52788

Summary by CodeRabbit

• Refactor

  • 优化了粘性滚动条组件的滚动检测机制，现在可识别多个父容器的滚动事件，从而提升滚动响应的流畅性。

• Bug Fixes

  • 改进了事件监听器的清理方式，确保在不需要时能及时移除，降低内存泄漏风险，提升组件稳定性。

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
table	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 14, 2025 7:17am

[coderabbitai]

"""

Walkthrough

该更改在 stickyScrollBar.tsx 文件中改进了滚动条组件的事件处理逻辑。修改包括：在执行可见性检查前取消之前的请求动画帧（rAF）；将滚动事件监听器添加到 scrollBodyRef.current 的所有父级元素；以及在清理阶段移除所有注册的事件监听器。依赖数组也从 container 更改为 scrollBodyRef.current。

Changes

文件	变更摘要
src/stickyScrollBar.tsx	- 在滚动事件处理前取消旧的 rAF 并请求新的 rAF - 将滚动事件监听器绑定到 scrollBodyRef.current 的所有父级元素 - 更新清理函数以移除所有添加的事件监听器 - 修改 useEffect 依赖项

Sequence Diagram(s)

sequenceDiagram
    participant U as 用户
    participant P as 父级元素
    participant S as StickyScrollBar组件
    U->>P: 触发滚动事件
    P->>S: 传递滚动通知
    S->>S: 检查并取消旧的 rAF
    S->>S: 请求新的 rAF
    S->>S: 更新滚动条可见性

Loading

Possibly related PRs

• change stickyScrollBar onMouseMove #1215: 该PR增强了滚动条的事件处理和可见性逻辑，与当前改动直接相关。

Suggested reviewers

• afc163

Poem

我是一只快乐的小兔子，
在代码的森林中蹦跳前行。
取消旧帧迎新节拍，
监听父元素声声响起。
滚动条轻轻展现神奇，
我在代码丛中欢欣跳跃！
(_/)(＾▽＾)
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/stickyScrollBar.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "prettier" to extend from. Please check that the name of the config is correct.

The config "prettier" was referenced from the config file in "/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 85007a4 and 100d0b5.

📒 Files selected for processing (1)

• src/stickyScrollBar.tsx (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/stickyScrollBar.tsx

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (9e4bc80) to head (100d0b5).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1231   +/-   ##
=======================================
  Coverage   97.76%   97.77%           
=======================================
  Files          76       76           
  Lines        7441     7453   +12     
  Branches     1128     1132    +4     
=======================================
+ Hits         7275     7287   +12     
  Misses        160      160           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e4bc80 and 85007a4.

📒 Files selected for processing (1)

• src/stickyScrollBar.tsx (2 hunks)

🔇 Additional comments (1)

src/stickyScrollBar.tsx (1)

97-99: 优化 RAF 处理逻辑！

在调度新的可见性检查之前取消之前的 RAF 回调，这样可以避免多个 RAF 回调之间的竞争条件，提高性能。