Support stretch porp #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
reviewed
Mar 30, 2018
| const { stretch, getRootDomNode, visible } = this.props; | ||
| const { stretchChecked, targetHeight, targetWidth } = this.state; | ||
|
|
||
| if (!stretch || !visible) { |
There was a problem hiding this comment.
yesmeck
reviewed
Mar 30, 2018
README.md
Outdated
| <td>stretch</td> | ||
| <td>string</td> | ||
| <td></td> | ||
| <td>Let popup div stretch with trigger element. enums of 'w', 'h'</td> |
There was a problem hiding this comment.
align 里面也是缩写，觉得一个缩写一个不缩写很怪异：
points: ['cr', 'cl']
yesmeck
reviewed
Mar 30, 2018
src/Popup.js
Outdated
| if (!$ele) return; | ||
|
|
||
| const height = $ele.clientHeight; | ||
| const width = $ele.clientWidth; |
yesmeck
approved these changes
Mar 30, 2018
yesmeck
approved these changes
Apr 2, 2018
|
这个没发布？ |
|
还没， |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stretch support. Will update
rc-tree-select&rc-selectfor this props.