Skip to content

Support stretch porp #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 2, 2018
Merged

Support stretch porp #82

merged 6 commits into from
Apr 2, 2018

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 30, 2018

Add stretch support. Will update rc-tree-select & rc-select for this props.

@zombieJ zombieJ requested a review from yesmeck March 30, 2018 02:04
const { stretch, getRootDomNode, visible } = this.props;
const { stretchChecked, targetHeight, targetWidth } = this.state;

if (!stretch || !visible) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
<td>stretch</td>
<td>string</td>
<td></td>
<td>Let popup div stretch with trigger element. enums of 'w', 'h'</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还是不要用缩写吧

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align 里面也是缩写,觉得一个缩写一个不缩写很怪异:

points: ['cr', 'cl']

src/Popup.js Outdated
if (!$ele) return;

const height = $ele.clientHeight;
const width = $ele.clientWidth;
Copy link
Member

@yesmeck yesmeck Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要用 getBoundingClientRect

@zombieJ zombieJ merged commit d2ec5c4 into react-component:master Apr 2, 2018
@afc163
Copy link
Member

afc163 commented Apr 18, 2018

这个没发布?

@zombieJ
Copy link
Member Author

zombieJ commented Apr 18, 2018

还没,rc-tree-selectrc-select 目前自己都实现了一把,不是很着急发版。
另外,这两个组件的 dropdownMatchSelectWidth 属性也和最初的设计不一样了,准备 antd 3.5 一起调整一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants