Skip to content

fix: onVirtualScroll should be triggered when scrollWidth changed #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Apr 28, 2024

scrollWidth 发生改变,onVirtualScroll 应该触发,这样能得到最新的正确的偏移值

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-list ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2024 2:45am

@linxianxi linxianxi force-pushed the fix-scrollWidth-trigger-onVirtualScroll branch from 23c3c38 to 78b8cf2 Compare April 28, 2024 02:13
@linxianxi linxianxi changed the title fix: should be trigger onVirtualScroll when scrollWidth changed fix: onVirtualScroll should be triggered when scrollWidth changed Apr 28, 2024
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (34ec0e7) to head (78b8cf2).
Report is 2 commits behind head on master.

❗ Current head 78b8cf2 differs from pull request most recent head ae0be6c. Consider uploading reports for the commit ae0be6c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   98.24%   98.39%   +0.15%     
==========================================
  Files          18       18              
  Lines         684      686       +2     
  Branches      163      163              
==========================================
+ Hits          672      675       +3     
+ Misses         12       11       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 98f6757 into react-component:master May 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants