Fix Authentication Flows Static and Dynamic Tab Issues #1419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-navigation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
VimDiesel123
changed the title
satya164
requested changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How it will work section
The current How it will work section is confusing. There is no code snippet in the Static tab. The code snippet which seems like it belongs in the Static tab of the How it will work section is inside of the Define the hooks section - even though it does not relate to defining hooks.
There is also a useful general explanation of how it will work which is only visible under the Dynamic tab. I've reorganized things to be more clear.
I've also tried to make the Static and Dynamic code snippets match each other more closely.
Define our screens section
The Define our screens section is similarly confusing. There is a section of text which pertains to the Dynamic tab but it appears in both the Static and the Dynamic tab.
Then there is a set of Tabs at the bottom. The code snippet in the Static Tab appears to be out of place but the code snippet in Dynamic Tab looks like it belongs inside the previous Dynamic tab. I've reorganized things to be more clear.
I've also removed a reference to an
isSignoutstate in the text which doesn't appear in the code until a later section.