Skip to content

Fix line-break problem in top page #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Fix line-break problem in top page #146

merged 2 commits into from
Feb 26, 2019

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Feb 24, 2019

Before:

image

image

After:

image

image

@smikitky smikitky changed the title Change h3's width to avoid weired linebreaks Fix line-break problem in top page Feb 24, 2019
@smikitky smikitky requested review from koba04 and potato4d February 24, 2019 08:05
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for ja-reactjs ready!

Built with commit 318bb24

https://deploy-preview-146--ja-reactjs.netlify.com

Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smikitky
Copy link
Member Author

(This may have to be fixed in the upstream reactjs.org. I feel the original maxWidth of 11em can cause trouble also in other languages.)

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koba04 koba04 merged commit febc8d0 into master Feb 26, 2019
@koba04
Copy link
Member

koba04 commented Feb 26, 2019

@smikitky Thank you!

@koba04 koba04 deleted the fix-toppage-layout branch February 27, 2019 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants