Sync with reactjs.org @ ddbd064d #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First pass at Profiler API docs
* Testing Docs This expands the testing docs for reactjs.org. It adds 3 main docs - - testing.md: An entry point to the testing docs - testing-recipes.md: Common patterns when writing tests for React Components. - testing-environments.md: Setting up your testing environment. With help from @alexkrolick, @kentcdodds, @gaearon
* Update testing-recipes.md Update timers section code to match described situation * Missed a spot
Type fix 'Diffrent' ➡️ 'Different'
2 small changes - consistent data-testid everywhere - one wrong assertion
"enountered" -> "encountered"
Nothing, fancy, just a list of links to the sections on the page. Also took the opportunity to add dividers between sections, and Title Case the titles.
"Get a hold" should be the phrasal verb "get ahold". See https://www.quickanddirtytips.com/education/grammar/a-hold-or-ahold?page=1
* Add a note about the codemod on the lifecycle warnings post https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html * missing fullstop. * Update 2018-03-27-update-on-async-rendering.md
added react conf iran 2019 to the list.
Add a new ReactJS hosted in Canarias 🇮🇨 (Spain)
Add resource/guide to learning React Hooks. An article inspired by the ReactJS.org documentation.
Closing #2193
* Update meetups.md Added Meetup link for the React Miami group * Update meetups.md Co-authored-by: Alexey Pyltsyn <[email protected]>
* Links to React Redux hooks api Since Hooks are already released for Redux, link the docs * Update hooks-faq.md Co-authored-by: Alexey Pyltsyn <[email protected]>
Spring is a popular library on top of motion with some useful developments
potato4d
reviewed
Aug 12, 2019
| @@ -0,0 +1,119 @@ | |||
| --- | |||
There was a problem hiding this comment.
React.js 本体のアップデートによって追加コンテンツが生えてきたので、一旦追加コンテンツはマージした上で翻訳用 Issue 建てましょうか。
There was a problem hiding this comment.
新規ページは英語のまま導入してあとで翻訳するということですよね。いわゆる「コンフリクト」ではないのでそれで大丈夫だと思います
| @@ -0,0 +1,58 @@ | |||
| --- | |||
|
Deploy preview for ja-reactjs ready! Built with commit 6ff11de |
smikitky
approved these changes
Aug 13, 2019
|
あれ、CIがこけてますね…確認します |
koba04
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at ddbd064
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.