-
Notifications
You must be signed in to change notification settings - Fork 181
Sync with reactjs.org @ de497e25 #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…246) The addition of the `TestRenderer.act()` method to the documentation broke the logical flow and "The returned instance has the following methods and properties." is now confusing since it's the `act()` method that is now documented afterwards. This commit aims at clarifying what is returned.
updated how to install babel presets to use the newer namespace conventions that comes with newer versions of Babel, version 7. My react app kept crashing when I tried installing Flow. I have updated the docs on Flow's documentation, then I saw the same issue here. Here is the PR on Flow's docs just in case - facebook/flow#7856
* Update conferences.md * Update conferences.md Co-authored-by: Alexey Pyltsyn <[email protected]>
Fix code indentation
Forgot to add a description for this link on the initial PR.
Already landed for a while now.
This feature isn't available in New DevTools (yet?)
For the FAQ question "Which versions of React include Hooks?", the current version of React Native (which supports Hooks) is now listed, along with a link to the blog post for that release.
Added meetup group of Chandigarh/India in the list.
Clarify that ‘only’ does not preclude `<Content />` from rendering.
Deploy preview for ja-reactjs ready! Built with commit 9df0651 |
CIが |
fa6ae09
to
9df0651
Compare
CI再実行してみたら問題ありませんでした |
koba04
approved these changes
Aug 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
potato4d
approved these changes
Sep 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at de497e2
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.