Skip to content

feat: Translate components #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 8, 2019
Merged

feat: Translate components #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e492132
feat: Tranlate CodeExample
potato4d Oct 6, 2019
8db47c0
feat: Translate CodeEditor
potato4d Oct 6, 2019
268eb0e
feat: Translate ErrorDecoder
potato4d Oct 6, 2019
61eced1
chore: Format with Prettier
potato4d Oct 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/components/CodeEditor/CodeEditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,11 @@ class CodeEditor extends Component {
if (showBabelErrorMessage) {
errorMessage = (
<span>
Babel could not be loaded.
Babel の読み込みに失敗しました。
<br />
<br />
This can be caused by an ad blocker. If you're using one, consider
adding reactjs.org to the whitelist so the live code examples will
work.
これは広告ブロッカーが原因である可能性があります。もし広告ブロッカーを利用している場合は、サンプルコードが機能させるために
ja.reactjs.org をホワイトリストに追加することを検討してください。
</span>
);
} else if (error != null) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/CodeExample/CodeExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class CodeExample extends Component {
{loaded ? (
<CodeEditor code={code} containerNodeID={containerNodeID} />
) : (
<h4>Loading code example...</h4>
<h4>サンプルコードを読み込んでいます……</h4>
)}
</div>
);
Expand Down
5 changes: 2 additions & 3 deletions src/components/ErrorDecoder/ErrorDecoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,15 @@ function ErrorResult(props: {|code: ?string, msg: string|}) {
if (!code) {
return (
<p>
When you encounter an error, you'll receive a link to this page for that
specific error and we'll show you the full error text.
エラーが発生したとき、そのエラーに関するこのページへのリンクを受け取り、エラー全体のテキストが表示されます。
</p>
);
}

return (
<div>
<p>
<b>The full text of the error you just encountered is:</b>
<b>発生したエラーの全文は以下です。</b>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここは is: でつながっていますが、日本語的にこういった表現はないので軽く意訳しています。

</p>
<code>
<b>{urlify(errorMsg)}</b>
Expand Down