Skip to content

Sync with reactjs.org @ 19aa5b48 #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Mar 17, 2023
Merged

Sync with reactjs.org @ 19aa5b48 #543

merged 29 commits into from
Mar 17, 2023

Conversation

react-translations-bot
Copy link
Collaborator

@react-translations-bot react-translations-bot commented Mar 13, 2023

This PR was automatically generated.

Merge changes from reactjs.org at 19aa5b4

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

myfreespirit and others added 28 commits February 6, 2023 12:01
* Move past conferences to past section

* Update ordering for past conferences, most recent first
Added `createElement` in the import statement since it was used within the code snippet but was not imported.
The rule is `exhaustive-deps`, not `exhaustive-dependencies`.

Signed-off-by: Eng Zer Jun <[email protected]>
It should be `useContext(AuthContext)` whereas it's `useContext(AuthProvider)`.
* Add React Norway to conferences page

* Add React Norway to beta docs events
* 🐛 (tic-tac-toe) fix or-and in sentence

* chore: use an just like previous para

---------

Co-authored-by: Delphine Bugner <[email protected]>
Co-authored-by: Strek <[email protected]>
ghstack-source-id: fd330d5eeb1e050d792064492193dfbdabee24a5
Pull Request resolved: reactjs/react.dev#5658
@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 89.2 KB (🟡 +11 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 43.84 KB (🟡 +6 B) 133.04 KB
/500 43.82 KB (🟡 +6 B) 133.02 KB
/[[...markdownPath]] 44.01 KB (🟡 +6 B) 133.21 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@smikitky
Copy link
Member

smikitky commented Mar 17, 2023

@koba04 @potato4d よろしくお願いします
次週のマージが大変かもしれないのでとりあえずこの時点で負債をなくしたいです

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@koba04 koba04 merged commit 01f48f6 into main Mar 17, 2023
@koba04 koba04 deleted the sync-19aa5b48 branch March 17, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.