Skip to content

Sync with react.dev @ 8ed23b1a #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 30, 2023
Merged

Sync with react.dev @ 8ed23b1a #561

merged 10 commits into from
Apr 30, 2023

Conversation

react-translations-bot
Copy link
Collaborator

This PR was automatically generated.

Merge changes from react.dev at 8ed23b1

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.

gaearon and others added 10 commits April 21, 2023 17:39
@gaearon
Disable dependabot
920f32e
@irshathcodes
fix form submit on enter (#5958)
dc1d580
@gaearon
Make bundle analysis workflow less fragile (#5971)
609533c 
* Make bundle analysis workflow less fragile

* Use sticky comment action
@gaearon
Fix the comment action
496c578
@gaearon
Document propTypes (#5974)
52c777b
@jeonghwan-kim
Fix typo in useMemo (product.id -> productId) (#5965)
7ea43a8
@M0nica
update chronological order of the React Miami conf (#5977)
fd621b8
@dexter-stpierre
Update Fragment.md (#5953)
ef55fb2 
The actual dom nodes that are siblings are the h1 and article nodes
@mattrunyon @gaearon
Add key param to createPortal reference (#5928)
8ed23b1 
* Add key param to createPortal reference

* Update createPortal.md

* Update createPortal.md

* Update createPortal.md

---------

Co-authored-by: dan <[email protected]>
@react-translations-bot
Merge branch 'main' of https://github.com/reactjs/react.dev into sync…
afd1560 
…-8ed23b1a
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.39 KB (🟡 +21 B) 170.02 KB
/500 76.39 KB (🟡 +21 B) 170.02 KB
/[[...markdownPath]] 77.81 KB (🟡 +21 B) 171.44 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@smikitky
Copy link
Member

あ、前はコンフリクトがない場合は全自動でPRなしでマージされてたと思うんですが、手動になったんですね…

@smikitky smikitky merged commit 306ce26 into main Apr 30, 2023
@smikitky smikitky deleted the sync-8ed23b1a branch April 30, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba04 koba04 koba04 approved these changes

@smikitky smikitky smikitky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@react-translations-bot @smikitky @koba04 @gaearon @irshathcodes @jeonghwan-kim @M0nica @dexter-stpierre @mattrunyon