Skip to content

Sync with reactjs.org @ b1691780 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2019
Merged

Sync with reactjs.org @ b1691780 #110

merged 9 commits into from
May 7, 2019

Conversation

reactjs-translation-bot
Copy link
Contributor

@reactjs-translation-bot reactjs-translation-bot commented May 3, 2019

This PR was automatically generated.

Merge changes from reactjs.org at b169178

The following files have conflicts and may need new translations:

Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.

DO NOT SQUASH MERGE THIS PULL REQUEST!

Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.

dantehemerson and others added 8 commits April 26, 2019 21:43
Add this functionality with gatsby-remark-external-links plugin
* add React Boston 2019 to conference page

* add massachusetts to react-boston listing
* Fix anchor link offset with fixed header

* handle h3 too

* h4 as an anchor

* don't affect UI by any means

* no need for px

* more fixes

* consistency

* more consistency

* pixel perfection

* fix h4 after gatsby-highlight

* final touch
The link should probably either go to directly to the beginning of main concepts (which is what my proposes change does), or to the anchor  -tag of "Step-by-Step Guide" (#step-by-step-guide). There is no other link in the article which refers to another anchor-tag, that's why I chose to directly link to the main-concepts.
Also add Mongolian and Catalan.
…st. (#1959)

* previous page link is not linking to the previous page, but to the second last.

The example code is on both, the `Introducing Hooks` as well as `Hooks at a Glance` page, but the linked page is the `Introducing Hooks` and I think that's the right one (the `Hooks at a Glance` page probably got added later?).

Not sure about the phrasing so, having "introduce" twice in one sentence ...

* Update content/docs/hooks-state.md

Co-Authored-By: 0xnoob <[email protected]>


Co-authored-by: Alexey Pyltsyn <[email protected]>
@netlify
Copy link

netlify bot commented May 3, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 08db893

https://deploy-preview-110--ko-reactjs-org.netlify.com

@@ -99,7 +99,11 @@ React 문서는 Javascript 프로그래밍에 익숙한 사람을 대상으로

### 고급 개념 {#advanced-concepts}

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -8,7 +8,11 @@ prev: hooks-overview.html

*Hook*은 React 16.8버전에 새로 추가되었습니다. Hook은 클래스 컴포넌트를 작성하지 않아도 state와 같은 특징들을 사용할 수 있습니다.

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock Outdated
@@ -11267,13 +11288,29 @@ [email protected]:
babel-runtime "^6.23.0"
fbjs "^0.8.14"

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock Outdated
@@ -13173,7 +13231,22 @@ unicode-property-aliases-ecmascript@^1.0.4:
resolved "https://registry.yarnpkg.com/unicode-property-aliases-ecmascript/-/unicode-property-aliases-ecmascript-1.0.4.tgz#5a533f31b4317ea76f17d807fa0d116546111dd0"
integrity sha512-2WSLa6OdYd2ng8oqiGIWnJqyFArvhn+5vgx5GTxMbUYjCYKUcuKS62YLFF0R/BDGlB1yzXjQOLtPAfHsgirEpg==

<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taehwanno taehwanno merged commit 7b68d74 into master May 7, 2019
@taehwanno taehwanno deleted the sync-b1691780 branch May 7, 2019 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants