Skip to content

Translate: useCallback #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 3, 2023
Merged

Translate: useCallback #667

merged 9 commits into from
Jun 3, 2023

Conversation

hayoiii
Copy link
Contributor

@hayoiii hayoiii commented May 24, 2023 •
edited
Loading

@hayoiii hayoiii mentioned this pull request May 24, 2023
Merged
6 tasks
@hg-pyun
Copy link
Member

hg-pyun commented May 24, 2023

@hayoiii 님 안녕하세요! 어사인 된 담당자를 인지하지 못하고, 머지해버린 부분 먼저 사죄의 말씀을 드립니다 🙇
#612 (comment) 에 남겨주신 코멘트를 지금 확인했는데요. 이전에 머지된 PR은 Revert하고, @hayoiii 님께서 번역해주신 걸 우선적으로 반영해보도록 하겠습니다. 감사합니다.

@hg-pyun
Copy link
Member

hg-pyun commented May 29, 2023

@hayoiii 님, Vercel CI가 현재 실패하고 있는데 확인 부탁드려도 될까요? 아래 코멘트가 도움이 될 것 같습니다. 🙇‍♂️
#643 (comment)

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

hg-pyun
hg-pyun reviewed May 31, 2023
View reviewed changes
src/content/reference/react/useCallback.md Outdated
@@ -34,34 +34,34 @@ export default function ProductPage({ productId, referrer, theme }) {
}, [productId, referrer]);
```

[See more examples below.](#usage)
[아래에서 더 많은 예시를 확인해보세요.](#usage)

#### Parameters {/*parameters*/}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glossary에 따라 매개변수로 변역하는게 좋을 것 같습니다.

gnujoow
gnujoow requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일부 표현에 대해서 더 자연스러운 표현이 있을것 같습니다. 이번 주중으로 추가 변경 사항을 제안을 올려두겠습니다.

gnujoow
gnujoow requested changes Jun 1, 2023
View reviewed changes
gnujoow
gnujoow previously approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gnujoow gnujoow merged commit 484fdca into reactjs:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun left review comments

@gnujoow gnujoow gnujoow approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno

@simsim0709 simsim0709 Awaiting requested review from simsim0709

@b9words b9words Awaiting requested review from b9words

@taggon taggon Awaiting requested review from taggon

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J

@eomttt eomttt Awaiting requested review from eomttt eomttt is a code owner

@goofcode goofcode Awaiting requested review from goofcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayoiii @hg-pyun @gnujoow