This repository was archived by the owner on Oct 26, 2018. It is now read-only.
rename syncHistoryToStore to listenForReplays #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't feel good pushing this out without any review, so I'm going to wait to push out 2.0.1 until tomorrow morning. |
|
LGTM. |
jlongster
added a commit
that referenced
this pull request
Jan 14, 2016
rename syncHistoryToStore to listenForReplays
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timdorr mentioned in #189 (comment) that this function is purely for devtools. I sort of forgot that it is completely for devtools, and because if this, I think we should rename the function. I propose
listenForReplays, given that that's the usual use case. It might not be a replay that triggers it, but that's not a huge deal, it's something like a replay.We can also mark this optional; people that don't use the devtools don't need it.