-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Added option for more cdns. #2144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Deploy preview for reactjs ready! Built with commit 2e333b5 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@praisedpk thank you! |
@lex111 I'd like to point out that while CDNJS is definitely a popular and trustworthy option which has been around for a long time, PageCDN is a completely new, unknown service, which has just launched this week. It looks like they are sending PRs like this to the most popular projects just to promote their business. |
@lex111 thanks. @MartinKolarik please see my PR comment. More discussion on this topic with another jsdelivr team member: rgrove/rawgit#200 The whole point is that we are trying to present this idea to everyone that current CDNs are under-performing and leave several optimizations on the table. |
The only under-performance point here is regarding the compression. That not the main performance metric of a CDN. For example https://www.cdnperf.com/ |
@jimaek Compression IS the main performance metric, but its not the only one.
You can see the difference of upto 128 KB between different compression levels. 128 KB can influence the decision of many users when selecting a CDN. And that's why I submitted PageCDN to react's docs just to give users more options to decide from. (Sure, react javascript files would not get the same level of savings from aggressive compression.)
Overall, we are using existing technologies and want to make the optimal use of it to fuel our research based on the data we collect. Yes, PageCDN is our business, but we plan to return a lot back to the community. Its not that we want to take advantage of popular libraries. The benefit is two ways. A lot will be returned back to the community. @jimaek I am following you for last so many years and learnt a lot reading your comments on github. I admit that following you and jsDelivr helped me a lot in my research. If you have any feedback that can help us improve, we can discuss here or on twitter. Thanks. |
https://www.cdnperf.com is a good resource. Thanks. |
This reverts commit b84fb3d.
This reverts commit b84fb3d.
Last time a new service (Codesandbox) came out that someone wanted to add to the docs, we waited several months to allow it to mature. Let's stick with that precedent. |
@alexkrolick I'm so sorry. It's my fault. That's good to know... |
Maybe its time to merge this PR again that was reverted by #2146 |
unpkg CDN is used throughout the react docs. The CDN Links page on documentation again uses the same unpkg code without providing option for other CDNs.
Added 2 new CDNs. CDNJS is insanely popular, while PageCDN compresses JS/CSS more tightly. Both can be a good addition to this page.