Skip to content

Update componentDidCatch argument name like demo #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2019
Merged

Update componentDidCatch argument name like demo #2180

merged 1 commit into from
Aug 12, 2019

Conversation

behnammodi
Copy link
Contributor

@behnammodi behnammodi commented Jul 31, 2019 •
edited
Loading 

- componentDidCatch(error, info) {    
-     logErrorToMyService(error, info);
+ componentDidCatch(error, errorInfo) {    
+     logErrorToMyService(error, errorInfo);

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit bd07093

https://deploy-preview-2180--reactjs.netlify.com

@lex111 lex111 merged commit 8cd5737 into reactjs:master Aug 12, 2019
@lex111
Copy link
Member

lex111 commented Aug 12, 2019

@uxitten thank you!

@behnammodi
Copy link
Contributor Author

@lex111 you're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@behnammodi @reactjs-bot @lex111 @facebook-github-bot