Rephrase confusing documentation about TestRenderer.create return value #2246
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
The addition of the `TestRenderer.act()` method to the documentation broke the logical flow and "The returned instance has the following methods and properties." is now confusing since it's the `act()` method that is now documented afterwards. This commit aims at clarifying what is returned.
|
Deploy preview for reactjs ready! Built with commit 277f8bc82e144643c75b57626ba8c456ca43a8dd |
|
Deploy preview for reactjs ready! Built with commit a6c3af4 |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thanks, this is great. |
Hello,
The addition of the
TestRenderer.act()method to the documentation broke the logical flow thus saying "The returned instance has the following methods and properties." is confusing now since theact()method is documented below (while it belongs to the TestRenderer class). This commit aims at clarifying what is returned.By the way, react rocks, thanks a lot! <3